netdev - Re: [PATCH bpf-next] net, xdp: allow metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231027130930.7d6014df@kernel.org>
Date: Fri, 27 Oct 2023 13:09:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Larysa Zaremba <larysa.zaremba@...el.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, Alexei Starovoitov
 <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jesper Dangaard Brouer <hawk@...nel.org>, Eric
 Dumazet <edumazet@...gle.com>, Magnus Karlsson <magnus.karlsson@...il.com>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Yunsheng Lin
 <linyunsheng@...wei.com>, Simon Horman <simon.horman@...igine.com>, Maciej
 Fijalkowski <maciej.fijalkowski@...el.com>, John Fastabend
 <john.fastabend@...il.com>, Aleksander Lobakin
 <aleksander.lobakin@...el.com>
Subject: Re: [PATCH bpf-next] net, xdp: allow metadata > 32

On Thu, 26 Oct 2023 18:56:59 +0200 Larysa Zaremba wrote:
>  static inline bool xdp_metalen_invalid(unsigned long metalen)
>  {
> -	return (metalen & (sizeof(__u32) - 1)) || (metalen > 32);
> +	typeof(metalen) meta_max;

The use of typeof() looks a bit unnecessary..