netdev - RE: [Patch v7 1/5] RDMA/mana_ib: Rename all mana_ib_dev type variables to mib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR21MB3264740D66154E9EEEA4620BCEDCA@MN0PR21MB3264.namprd21.prod.outlook.com>
Date: Fri, 27 Oct 2023 22:00:50 +0000
From: Long Li <longli@...rosoft.com>
To: Jason Gunthorpe <jgg@...pe.ca>, "sharmaajay@...uxonhyperv.com"
	<sharmaajay@...uxonhyperv.com>
CC: Leon Romanovsky <leon@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Wei
 Liu <wei.liu@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Ajay Sharma <sharmaajay@...rosoft.com>
Subject: RE: [Patch v7 1/5] RDMA/mana_ib: Rename all mana_ib_dev type
 variables to mib_dev

> Subject: Re: [Patch v7 1/5] RDMA/mana_ib: Rename all mana_ib_dev type
> variables to mib_dev
> 
> On Mon, Oct 16, 2023 at 03:11:58PM -0700,
> sharmaajay@...uxonhyperv.com wrote:
> > From: Ajay Sharma <sharmaajay@...rosoft.com>
> >
> > This patch does not introduce any functional changes. It creates
> > naming convention to distinguish especially when used in the same
> > function.Renaming all mana_ib_dev type variables to mib_dev to have
> > clean separation between eth dev and ibdev variables.
> 
> > Signed-off-by: Ajay Sharma <sharmaajay@...rosoft.com>
> > ---
> >  drivers/infiniband/hw/mana/cq.c      | 12 ++--
> >  drivers/infiniband/hw/mana/device.c  | 34 +++++------
> >  drivers/infiniband/hw/mana/main.c    | 87 ++++++++++++++--------------
> >  drivers/infiniband/hw/mana/mana_ib.h |  9 +--
> >  drivers/infiniband/hw/mana/mr.c      | 29 +++++-----
> >  drivers/infiniband/hw/mana/qp.c      | 84 +++++++++++++--------------
> >  drivers/infiniband/hw/mana/wq.c      | 21 +++----
> >  7 files changed, 141 insertions(+), 135 deletions(-)
> 
> Please no, don't create pointless giant churn like this. It only hurts backporters
> 
> Maybe just target the functions with more than one type
> 
> Jason

Yes, we will drop this patch.

Thanks,

Long