netdev - Re: [PATCH net-next 2/4] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231027045219.GK3803936@pengutronix.de>
Date: Fri, 27 Oct 2023 06:52:19 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net-next 2/4] net: fill in MODULE_DESCRIPTION()s under
 net/core

On Thu, Oct 26, 2023 at 12:00:59PM -0700, Jakub Kicinski wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: o.rempel@...gutronix.de
> ---
>  net/core/dev_addr_lists_test.c | 1 +
>  net/core/selftests.c           | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/net/core/dev_addr_lists_test.c b/net/core/dev_addr_lists_test.c
> index 90e7e3811ae7..4dbd0dc6aea2 100644
> --- a/net/core/dev_addr_lists_test.c
> +++ b/net/core/dev_addr_lists_test.c
> @@ -233,4 +233,5 @@ static struct kunit_suite dev_addr_test_suite = {
>  };
>  kunit_test_suite(dev_addr_test_suite);
>  
> +MODULE_DESCRIPTION("KUnit tests for struct netdev_hw_addr_list");
>  MODULE_LICENSE("GPL");
> diff --git a/net/core/selftests.c b/net/core/selftests.c
> index 94fe3146a959..8f801e6e3b91 100644
> --- a/net/core/selftests.c
> +++ b/net/core/selftests.c
> @@ -405,5 +405,6 @@ void net_selftest_get_strings(u8 *data)
>  }
>  EXPORT_SYMBOL_GPL(net_selftest_get_strings);
>  
> +MODULE_DESCRIPTION("Common library for generic PHY ethtool selftests");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Oleksij Rempel <o.rempel@...gutronix.de>");
> -- 
> 2.41.0

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |