netdev - Re: [PATCH net-next v4 2/2] net:dsa:microchip: add property to select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231027063743.28747-1-ante.knezic@helmholz.de>
Date: Fri, 27 Oct 2023 08:37:43 +0200
From: Ante Knezic <ante.knezic@...mholz.de>
To: <olteanv@...il.com>
CC: <o.rempel@...gutronix.de>, <UNGLinuxDriver@...rochip.com>,
	<andrew@...n.ch>, <ante.knezic@...mholz.de>, <conor+dt@...nel.org>,
	<davem@...emloft.net>, <devicetree@...r.kernel.org>, <edumazet@...gle.com>,
	<f.fainelli@...il.com>, <krzysztof.kozlowski+dt@...aro.org>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, <marex@...x.de>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <robh+dt@...nel.org>,
	<woojung.huh@...rochip.com>
Subject: Re: [PATCH net-next v4 2/2] net:dsa:microchip: add property to select

On Tue, 24 Oct 2023 16:24:26 +0200, Oleksij Rampel wrote:

> > That is correct, I guess its a matter of nomenclature, but how do you 
> > "tell" the switch whether it has REFCLKI routed externally or not if not by 
> > setting the 0xC6 bit 3? Is there another way to achieve this?
> 
> I do not see any other way to "tell" it. The only thing to change in you
> patches is a different way to tell it to the kernel.
> Instead of introducing a new devicetree property, you need to reuse
> phy-mode property.

> ...

> Since phy-mode for RMII was never set correctly, it will most probably
> break every single devicetree using KSZ switches. It is the price of fixing
> things :/

To Vladimir Oltean: What are your thoughts on this?