lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1e8b5a62-047a-4b87-9815-0ea320ccc466@proton.me> Date: Sat, 28 Oct 2023 11:41:52 +0000 From: Benno Lossin <benno.lossin@...ton.me> To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Andrew Lunn <andrew@...n.ch> Cc: Jakub Kicinski <kuba@...nel.org>, FUJITA Tomonori <fujita.tomonori@...il.com>, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, tmgross@...ch.edu, wedsonaf@...il.com Subject: Re: [PATCH net-next v7 0/5] Rust abstractions for network PHY drivers On 10/28/23 13:07, Miguel Ojeda wrote: > On Sat, Oct 28, 2023 at 12:55 AM Andrew Lunn <andrew@...n.ch> wrote: >> It should also be noted that 80, or 100, is not a strict limit. Being >> able to grep the kernel for strings is important. So the coding >> standard allows you to go passed this limit in order that you don't >> need to break a string. checkpatch understands this. I don't know if >> your automated tools support such exceptions. > > Not breaking string literals is the default behavior of `rustfmt` (and > we use its default behavior). > > It is also definitely possible to turn off `rustfmt` locally, i.e. for > particular "items" (e.g. a function, a block, a statement), rather > than lines, which is very convenient. > > However, as far as I recall, we have never needed to disable it. I am > sure it will eventually be needed somewhere, but what I am trying to > say is that it works well enough that one can just use it. We have it disabled on the `pub mod code` in error.rs line 20: https://elixir.bootlin.com/linux/latest/source/rust/kernel/error.rs#L20 -- Cheers, Benno
Powered by blists - more mailing lists