lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <59be18ff-dabc-2a07-3d78-039461b0f3f7@iogearbox.net> Date: Sat, 28 Oct 2023 09:06:44 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Peilin Ye <yepeilin.cs@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org> Cc: Peilin Ye <peilin.ye@...edance.com>, netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, Cong Wang <cong.wang@...edance.com>, Jiang Wang <jiang.wang@...edance.com>, Youlun Zhang <zhangyoulun@...edance.com> Subject: Re: [PATCH net] veth: Fix RX stats for bpf_redirect_peer() traffic Hi Peilin, On 10/27/23 9:02 PM, Peilin Ye wrote: > On Fri, Oct 27, 2023 at 06:46:57PM +0000, Peilin Ye wrote: >> diff --git a/net/core/filter.c b/net/core/filter.c >> index 21d75108c2e9..7aca28b7d0fd 100644 >> --- a/net/core/filter.c >> +++ b/net/core/filter.c >> @@ -2492,6 +2492,7 @@ int skb_do_redirect(struct sk_buff *skb) >> net_eq(net, dev_net(dev)))) >> goto out_drop; >> skb->dev = dev; >> + dev_sw_netstats_rx_add(dev, skb->len); > > This assumes that all devices that support BPF_F_PEER (currently only > veth) use tstats (instead of lstats, or dstats) - is that okay? Dumb question, but why all this change and not simply just call ... dev_lstats_add(dev, skb->len) ... on the host dev ? > If not, should I add another NDO e.g. ->ndo_stats_rx_add()? Definitely no new stats ndo resp indirect call in fast path. Thanks, Daniel
Powered by blists - more mailing lists