netdev - Re: [PATCH net] net: page_pool: add missing free_percpu when page_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOBf=mvvnfv6HcG7D5Oo9p3F9nr1k9rRdqMP_N1ZnRG9foGZxQ@mail.gmail.com>
Date: Mon, 30 Oct 2023 19:14:14 +0530
From: Somnath Kotur <somnath.kotur@...adcom.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Jijie Shao <shaojijie@...wei.com>, hawk@...nel.org, ilias.apalodimas@...aro.org, 
	davem@...emloft.net, edumazet@...gle.com, Jakub Kicinski <kuba@...nel.org>, 
	pabeni@...hat.com, jdamato@...tly.com, shenjian15@...wei.com, 
	wangjie125@...wei.com, liuyonglong@...wei.com, linyunsheng@...wei.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: page_pool: add missing free_percpu when
 page_pool_init fail

On Mon, 30 Oct, 2023, 18:02 Jiri Pirko, <jiri@...nulli.us> wrote:

> Mon, Oct 30, 2023 at 10:12:56AM CET, shaojijie@...wei.com wrote:
> >From: Jian Shen <shenjian15@...wei.com>
> >
> >When ptr_ring_init() returns failure in page_pool_init(), free_percpu()
> >is not called to free pool->recycle_stats, which may cause memory
> >leak.
>
> Would be nice to see the use of imperative mood in the patch description
> too, not only patch subject. Nevertheless, fix looks fine:
>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
>
>
Reviewed-by: Somnath Kotur
>
<somnath.kotur@...adcom.com >

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)