netdev - Re: [PATCH net-next v7] vxlan: add support for flowlabel inherit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67d2a73d-c2a6-4d66-ba7d-4aae77360f25@bernat.ch>
Date: Mon, 30 Oct 2023 20:18:23 +0100
From: Vincent Bernat <vincent@...nat.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Alce Lafranque <alce@...ranque.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
 Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v7] vxlan: add support for flowlabel inherit

On 2023-10-26 18:04, Jakub Kicinski wrote:
> On Thu, 26 Oct 2023 17:53:22 +0200 Vincent Bernat wrote:
>>>> +	enum ifla_vxlan_label_policy	label_policy;
>>>
>>> Here, OTOH, you could save some space, by making it a u8.
>>
>> Is it worth it?
> 
> I'm just pointing out the irony of trying to save space in netlink,
> where everything is aligned to 4B, and not trying where it may actually
> matter :)

OK, let's fix this by using 4B for the netlink attribute, but we keep 
the enum unless you object strongly on this matter.  Also, just using u8 
wouldn't save space as `flags' would introduce a 3B padding, so we would 
also need to move it at the end.