lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <6b91a6df-4549-4ca8-9659-c6107f4f8c75@linaro.org> Date: Mon, 30 Oct 2023 08:27:24 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Emil Renner Berthing <kernel@...il.dk>, Samin Guo <samin.guo@...rfivetech.com>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Richard Cochran <richardcochran@...il.com>, Giuseppe Cavallaro <peppe.cavallaro@...com> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, kernel@...labora.com Subject: Re: [PATCH v2 02/12] dt-bindings: net: starfive,jh7110-dwmac: Drop superfluous select On 29/10/2023 22:08, Cristian Ciocaltea wrote: > On 10/29/23 13:18, Krzysztof Kozlowski wrote: >> On 29/10/2023 05:27, Cristian Ciocaltea wrote: >>> The usage of 'select' doesn't seem to have any influence on how this >>> binding schema is applied to the nodes, hence remove it. >>> >> >> It has. Why do you think it doesn't? You should see new errors from >> dwmac schema. > > This patch came as a result of testing both variants (w/ and w/o > 'select') with several different compatible strings and seeing > consistent output: > > - "starfive,jh7110-dwmac", "invalid"; > - "starfive,jh7110-dwmac"; > - "invalid", "snps,dwmac-5.20"; > - "invalid" > > Did I miss something? Testing all bindings? The select is there to prevent matching unrelated bindings. Best regards, Krzysztof
Powered by blists - more mailing lists