lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <PH0PR11MB5013F399AFD55F21D31E660796A1A@PH0PR11MB5013.namprd11.prod.outlook.com> Date: Mon, 30 Oct 2023 07:46:48 +0000 From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com> To: Marcin Szycik <marcin.szycik@...ux.intel.com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michal Swiatkowski <michal.swiatkowski@...ux.intel.com> Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VF-VF direction matching in drop rule in switchdev > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of > Marcin Szycik > Sent: Wednesday, October 25, 2023 8:17 PM > To: intel-wired-lan@...ts.osuosl.org > Cc: netdev@...r.kernel.org; Marcin Szycik <marcin.szycik@...ux.intel.com>; > Michal Swiatkowski <michal.swiatkowski@...ux.intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VF-VF direction matching in > drop rule in switchdev > > When adding a drop rule on a VF, rule direction is not being set, which > results in it always being set to ingress (ICE_ESWITCH_FLTR_INGRESS equals > 0). Because of this, drop rules added on port representors don't match any > packets. > > To fix it, set rule direction in drop action to egress when netdev is a port > representor, otherwise set it to ingress. > > Fixes: 0960a27bd479 ("ice: Add direction metadata") > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com> > Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com> > --- > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 24 ++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>
Powered by blists - more mailing lists