netdev - Re: [PATCH net-next v2 2/3] dt-bindings: net: dsa: realtek: add reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z6wcj7NY_XqJ-80yN+6=Z+fOCZqpXH60pL29jcE+zTugg@mail.gmail.com>
Date: Mon, 30 Oct 2023 19:30:45 -0300
From: Luiz Angelo Daros de Luca <luizluca@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk, 
	andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, 
	olteanv@...il.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	krzk+dt@...nel.org, arinc.unal@...nc9.com, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] dt-bindings: net: dsa: realtek: add reset controller

> On Fri, Oct 27, 2023 at 04:00:56PM -0300, Luiz Angelo Daros de Luca wrote:
> > Realtek switches can use a reset controller instead of reset-gpios.
> >
> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> > Cc: devicetree@...r.kernel.org
> > ---
> >  .../devicetree/bindings/net/dsa/realtek.yaml  | 75 +++++++++++++++++++
> >  1 file changed, 75 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > index 46e113df77c8..ef7b27c3b1a3 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > @@ -59,6 +59,9 @@ properties:
> >      description: GPIO to be used to reset the whole device
> >      maxItems: 1
> >
> > +  resets:
> > +    maxItems: 1
> > +
> >    realtek,disable-leds:
> >      type: boolean
> >      description: |
> > @@ -385,3 +388,75 @@ examples:
> >                      };
> >              };
> >        };
> > +
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    platform {
> > +            switch {
> > +                    compatible = "realtek,rtl8365mb";
> > +                    mdc-gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
> > +                    mdio-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
> > +
> > +                    resets = <&rst 8>;
> > +
> > +                    ethernet-ports {
> > +                            #address-cells = <1>;
> > +                            #size-cells = <0>;
> > +
> > +                            ethernet-port@0 {
> > +                                    reg = <0>;
> > +                                    label = "wan";
> > +                                    phy-handle = <&ethphy-0>;
> > +                            };
> > +                            ethernet-port@1 {
> > +                                    reg = <1>;
> > +                                    label = "lan1";
> > +                                    phy-handle = <&ethphy-1>;
> > +                            };
> > +                            ethernet-port@2 {
> > +                                    reg = <2>;
> > +                                    label = "lan2";
> > +                                    phy-handle = <&ethphy-2>;
> > +                            };
> > +                            ethernet-port@3 {
> > +                                    reg = <3>;
> > +                                    label = "lan3";
> > +                                    phy-handle = <&ethphy-3>;
> > +                            };
> > +                            ethernet-port@4 {
> > +                                    reg = <4>;
> > +                                    label = "lan4";
> > +                                    phy-handle = <&ethphy-4>;
> > +                            };
> > +                            ethernet-port@5 {
> > +                                    reg = <5>;
> > +                                    ethernet = <&eth0>;
> > +                                    phy-mode = "rgmii";
> > +                                    fixed-link {
> > +                                            speed = <1000>;
> > +                                            full-duplex;
> > +                                    };
> > +                            };
> > +                    };
> > +
> > +                    mdio {
> > +                            compatible = "realtek,smi-mdio";
> > +                            #address-cells = <1>;
> > +                            #size-cells = <0>;
> > +
> > +                            ethphy-0: ethernet-phy@0 {
>
> You didn't test your binding (make dt_binding_check).
>
> '-' is not valid in labels.
>

My bad. I (wrongly) fixed that in the realtek.example.dtb content,
which is derived from the realtek.yaml.
As it has a newer mtime, it was not updated with dt_binding_check.

>
> Why do we have a whole other example just for 'resets' instead of
> 'reset-gpios'? That's not really worth it.

However, as it is not worth it, I'll drop it.

> Rob