netdev - Re: [PATCH net v3] net: stmmac: xgmac: Enable support for multiple Flexible PPS outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <988c1d61-ac0b-452c-9a99-04f59145598a@intel.com>
Date: Tue, 31 Oct 2023 12:47:57 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Furong Xu <0x1207@...il.com>, "David S. Miller" <davem@...emloft.net>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
	<joabreu@...opsys.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Joao Pinto <jpinto@...opsys.com>, Simon Horman
	<horms@...nel.org>, Serge Semin <fancer.lancer@...il.com>
CC: <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<xfr@...look.com>, <rock.xu@....com>
Subject: Re: [PATCH net v3] net: stmmac: xgmac: Enable support for multiple
 Flexible PPS outputs



On 10/30/2023 7:27 PM, Furong Xu wrote:
> From XGMAC Core 3.20 and later, each Flexible PPS has individual PPSEN bit
> to select Fixed mode or Flexible mode. The PPSEN must be set, or it stays
> in Fixed PPS mode by default.
> XGMAC Core prior 3.20, only PPSEN0(bit 4) is writable. PPSEN{1,2,3} are
> read-only reserved, and they are already in Flexible mode by default, our
> new code always set PPSEN{1,2,3} do not make things worse ;-)
> 
> Fixes: 95eaf3cd0a90 ("net: stmmac: dwxgmac: Add Flexible PPS support")
> Reviewed-by: Serge Semin <fancer.lancer@...il.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Furong Xu <0x1207@...il.com>
> ---
> Changes in v3:
>   - Tagged Fixes: and sent through net instead of net-next, thanks Jacob Keller.
> 

Thanks!

-Jake