lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89i+_xggUyAc4F3vBuH=5PtkCfrLcF77poKJU2N1BMc_1MA@mail.gmail.com> Date: Wed, 1 Nov 2023 05:51:05 +0100 From: Eric Dumazet <edumazet@...gle.com> To: Dan Carpenter <dan.carpenter@...aro.org> Cc: Dmitry Safonov <0x7f454c46@...il.com>, "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net] net/tcp_sigpool: Fix some off by one bugs On Tue, Oct 31, 2023 at 10:51 AM Dan Carpenter <dan.carpenter@...aro.org> wrote: > > The "cpool_populated" variable is the number of elements in the cpool[] > array that have been populated. It is incremented in > tcp_sigpool_alloc_ahash() every time we populate a new element. > Unpopulated elements are NULL but if we have populated every element then > this code will read one element beyond the end of the array. > > Fixes: 8c73b26315aa ("net/tcp: Prepare tcp_md5sig_pool for TCP-AO") > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org> > --- > From static analysis and review. > Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists