netdev - Re: [PATCH] [PATCH net] tg3: power down device only on SYSTEM_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv37sniGKkYADvHwwMjFzp5tBbBnpfOnyK-peM=rnp63Bw@mail.gmail.com>
Date: Wed, 1 Nov 2023 20:50:03 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: George Shuklin <george.shuklin@...il.com>
Cc: netdev@...r.kernel.org, Andrew Gospodarek <andrew.gospodarek@...adcom.com>, 
	Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH] [PATCH net] tg3: power down device only on SYSTEM_POWER_OFF

On Wed, Nov 1, 2023 at 6:34 PM George Shuklin <george.shuklin@...il.com> wrote:
>
> Dell R650xs servers hangs if tg3 driver calls tg3_power_down.
>
> This happens only if network adapters (BCM5720 for R650xs) were
> initialized using SNP (e.g. by booting ipxe.efi).
>
> This is partial revert of commit 2ca1c94ce0b.
>
> The actual problem is on Dell side, but this fix allow servers
> to come back alive after reboot.

How are you sure that the problem solved by 2ca1c94ce0b is not
reintroduced with this change?

> ---
>  drivers/net/ethernet/broadcom/tg3.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 14b311196b8f..22b00912f7ac 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -18078,7 +18078,8 @@ static void tg3_shutdown(struct pci_dev *pdev)
>         if (netif_running(dev))
>                 dev_close(dev);
>
> -       tg3_power_down(tp);
> +       if (system_state == SYSTEM_POWER_OFF)
> +               tg3_power_down(tp);
>
>         rtnl_unlock();
>
> --
> 2.42.0
>
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)