lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231102141334.6hd4b3xsdnlvgf4j@skbuf> Date: Thu, 2 Nov 2023 16:13:34 +0200 From: Vladimir Oltean <olteanv@...il.com> To: Luiz Angelo Daros de Luca <luizluca@...il.com> Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org, krzk+dt@...nel.org, arinc.unal@...nc9.com Subject: Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset controller On Mon, Oct 30, 2023 at 09:30:45PM -0300, Luiz Angelo Daros de Luca wrote: > The remove/shutdown are probably similar to any other DSA driver. I > think the extra code around a shared code in a new module would be > bigger than the duplicated code. When you start looking at the duplicated parsing of vendor-specific OF properties like "realtek,disable-leds", I am starting to question that. There are also differences in the handling of the user_mii_bus, which stem from the duplicate implementations, which are hard to justify if you are saying that the only difference is that the switch is controlled through a different interface and it is otherwise the same.
Powered by blists - more mailing lists