netdev - Re: [PATCH] net/mlx5: Fix reserved at offset in mlx5_ifc_fte_match_set_lyr_2_4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 02 Nov 2023 11:17:26 -0700
From: Rahul Rameshbabu <rrameshbabu@...dia.com>
To: Asbjørn Sloth Tønnesen
 <ast@...erby.net>
Cc: Saeed Mahameed <saeedm@...dia.com>,  Leon Romanovsky <leon@...nel.org>,
  Yevgeny Kliteynik <kliteyn@...dia.com>,  Muhammad Sammar
 <muhammads@...dia.com>,  Alex Vesker <valex@...dia.com>,
  netdev@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: Fix reserved at offset in
 mlx5_ifc_fte_match_set_lyr_2_4_bits

On Thu, 02 Nov, 2023 17:59:22 +0000 Asbjørn Sloth Tønnesen <ast@...erby.net> wrote:
> A member of struct mlx5_ifc_fte_match_set_lyr_2_4_bits has been mistakenly
> assigned the wrong reserved_at offset value. Correct it to align to the
> right value, thus avoid future miscalculation.
>
> Fixes: 5c422bfad2fb ("net/mlx5: DR, Add support for matching on Internet Header Length (IHL)")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
> ---
>  include/linux/mlx5/mlx5_ifc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 4df6d1c12437..09c50e786ff4 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -552,7 +552,7 @@ struct mlx5_ifc_fte_match_set_lyr_2_4_bits {
>  
>  	u8         reserved_at_c0[0x10];
>  	u8         ipv4_ihl[0x4];
> -	u8         reserved_at_c4[0x4];
> +	u8         reserved_at_d4[0x4];
>  
>  	u8         ttl_hoplimit[0x8];

In general, patches should target one of net or net-next on the netdev
mailing list as a heads up.

  https://docs.kernel.org/process/maintainer-netdev.html#tl-dr

Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>