netdev - RE: [EXT] Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB191810A4412D51D2D396617CD3A6A@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Thu, 2 Nov 2023 02:31:32 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "wojciech.drewek@...el.com"
	<wojciech.drewek@...el.com>
Subject: RE: [EXT] Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error
 code

> From: Paolo Abeni <pabeni@...hat.com>
> Subject: [EXT] Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error code
> 
> On Fri, 2023-10-27 at 07:49 +0530, Ratheesh Kannoth wrote:
> > Error code strings are not getting printed properly due to holes.
> > Print error code as well.
> error",
> >  					   qidx);
> >  			if (val & BIT_ULL(NIX_CQERRINT_CQE_FAULT))
> > -				netdev_err(pf->netdev, "CQ%lld: Memory
> fault on CQE write to LLC/DRAM",
> > +				netdev_err(pf->netdev,
> > +					   "CQ%lld: Memory fault on CQE
> write to LLC/DRAM",
> >  					   qidx);
> >  		}
> 
> It's not a big deal (no need to repost just for this), but the above chunk (and
> a couple below, too) is not related to the current fix, you should have not
> included it here.
I understand your point. But, Commit message says "Print error code as well".  When I added code to print it, it crossed 80 column mark,
so checkpatch script threw warning. So I splitted lines. Actually , there is not much change here. 

-Ratheesh