[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231102052902.3272319-1-alexey.pakhunov@spacex.com>
Date: Wed, 1 Nov 2023 22:29:02 -0700
From: <alexey.pakhunov@...cex.com>
To: <michael.chan@...adcom.com>
CC: <alexey.pakhunov@...cex.com>, <linux-kernel@...r.kernel.org>,
<mchan@...adcom.com>, <netdev@...r.kernel.org>,
<prashant@...adcom.com>, <siva.kallam@...adcom.com>,
<vincent.wong2@...cex.com>
Subject: Re: [PATCH 2/2] tg3: Fix the TX ring stall
> > Let me re-test the goto version and resubmit it as v2. Please let me know
> > which version of the patch you prefer more.
> >
>
> I did not realize the goto version is almost as big. In that case,
> your original version is fine.
>
> You might want to declare the variables in reverse Xmas tree style for
> any new code. This driver is old and most of the existing code does
> not follow that style.
Copy, thanks. I'll reorder the locals in tg3_start_xmit() and resubmit that
as v2.
Alex.
Powered by blists - more mailing lists