netdev - RE: [PATCH RFC net-next v2 0/2] selftests/dpll: DPLL subsystem integration tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CH3PR11MB841409F56A8857162B39D1AAE3A5A@CH3PR11MB8414.namprd11.prod.outlook.com>
Date: Fri, 3 Nov 2023 17:45:09 +0000
From: "Michalik, Michal" <michal.michalik@...el.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, "Kubalewski,
 Arkadiusz" <arkadiusz.kubalewski@...el.com>, "jonathan.lemon@...il.com"
	<jonathan.lemon@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>, poros
	<poros@...hat.com>, "Olech, Milena" <milena.olech@...el.com>, mschmidt
	<mschmidt@...hat.com>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "bvanassche@....org" <bvanassche@....org>,
	"kuba@...nel.org" <kuba@...nel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>
Subject: RE: [PATCH RFC net-next v2 0/2] selftests/dpll: DPLL subsystem
 integration tests

On 31 October 2023 10:47 AM CET, Jiri Pirko wrote:

Jiri, much thanks for taking time and doing great review - I have learned
a lot, especially in patch 1/2 having the netdevsim DPLL implementation.

I will do my best to post the RFC v3 early next week.

> 
> Mon, Oct 30, 2023 at 05:53:24PM CET, michal.michalik@...el.com wrote:
>>The recently merged common DPLL interface discussed on a newsletter[1]
> 
> "newsletter"? Sounds a bit odd to me :)
> 

Yeah, you are right - will fix.

>>is introducing new, complex subsystem which requires proper integration
>>testing - this patch adds core for such framework, as well as the
> 
> "Patchset" perhaps? Also, what do you mean by "core"? The sentence
> sounds a bit weird to me.
> 

Will work to improve this.

>>initial test cases. Framework does not require neither any special
>>hardware nor any special system architecture.
>>
>>To properly test the DPLL subsystem this patch adds fake DPLL devices and it's
> 
> For patch desctiption, please stay within 72cols.
> Also, "it's" is most probably wrong in this sentence.
> 

Improve this as well.

>>pins implementation to netdevsim. Creating netdevsim devices and adding ports
>>to it register new DPLL devices and pins. First port of each netdevsim device
> 
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This sentence does not make
> sense to me. Pehaps rephrase a bit?
> 
> 
>>acts as a entitiy which registers two DPLL devices: EEC and PPS DPLLs. First
> 
> typo: "entitiy"

Ok.

>>port also register the common pins: PPS and GNSS. Additionally each port
>>register also RCLK (recovered clock) pin for itself. That allow us to check
>>mutliple scenarios which might be problematic in real implementations (like
>>different ordering etc.)
>>
>>Patch adds few helper scripts, which are:
>>1) tools/testing/selftests/dpll/run_dpll_tests.sh
> 
> Please make this part of
> tools/testing/selftests/drivers/net/netdevsim/
> No special threat of dpll needed.
> 

That make a lot of sense to move it there, thanks for noticing that.

>>    Script is checking for all dependencies, creates temporary
>>    environment, installs required libraries and run all tests - can be
>>    used standalone
>>2) tools/testing/selftests/dpll/ynlfamilyhandler.py╦Ö
>>    Library for easier ynl use in the pytest framework - can be used
>>    standalone
>>
>>[1] https://lore.kernel.org/netdev/169494842736.21621.10730860855645661664.git-patchwork-notify@kernel.org/
>>
>>Changelog:
>>v1 -> v2:
>>- moved from separate module to implementation in netdevsim
>>
>>Michal Michalik (2):
>>  netdevsim: implement DPLL for subsystem selftests
>>  selftests/dpll: add DPLL system integration selftests
>>
>> drivers/net/Kconfig                              |   1 +
>> drivers/net/netdevsim/Makefile                   |   2 +-
>> drivers/net/netdevsim/dpll.c                     | 438 +++++++++++++++++++++++
>> drivers/net/netdevsim/dpll.h                     |  81 +++++
>> drivers/net/netdevsim/netdev.c                   |  20 ++
>> drivers/net/netdevsim/netdevsim.h                |   4 +
>> tools/testing/selftests/Makefile                 |   1 +
>> tools/testing/selftests/dpll/Makefile            |   8 +
>> tools/testing/selftests/dpll/__init__.py         |   0
>> tools/testing/selftests/dpll/config              |   2 +
>> tools/testing/selftests/dpll/consts.py           |  34 ++
>> tools/testing/selftests/dpll/dpll_utils.py       | 109 ++++++
>> tools/testing/selftests/dpll/requirements.txt    |   3 +
>> tools/testing/selftests/dpll/run_dpll_tests.sh   |  75 ++++
>> tools/testing/selftests/dpll/test_dpll.py        | 414 +++++++++++++++++++++
>> tools/testing/selftests/dpll/ynlfamilyhandler.py |  49 +++
>> 16 files changed, 1240 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/net/netdevsim/dpll.c
>> create mode 100644 drivers/net/netdevsim/dpll.h
>> create mode 100644 tools/testing/selftests/dpll/Makefile
>> create mode 100644 tools/testing/selftests/dpll/__init__.py
>> create mode 100644 tools/testing/selftests/dpll/config
>> create mode 100644 tools/testing/selftests/dpll/consts.py
>> create mode 100644 tools/testing/selftests/dpll/dpll_utils.py
>> create mode 100644 tools/testing/selftests/dpll/requirements.txt
>> create mode 100755 tools/testing/selftests/dpll/run_dpll_tests.sh
>> create mode 100644 tools/testing/selftests/dpll/test_dpll.py
>> create mode 100644 tools/testing/selftests/dpll/ynlfamilyhandler.py
>>
>>-- 
>>2.9.5
>>
>>base-commit: 55c900477f5b3897d9038446f72a281cae0efd86