netdev - RE: [PATCH] net/smc: avoid atomic_set and smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cadd420741145b897cc18237ce78688@baidu.com>
Date: Fri, 3 Nov 2023 04:43:40 +0000
From: "Li,Rongqing" <lirongqing@...du.com>
To: "dust.li@...ux.alibaba.com" <dust.li@...ux.alibaba.com>,
	"linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path when
 possible



> -----Original Message-----
> From: Dust Li <dust.li@...ux.alibaba.com>
> Sent: Thursday, November 2, 2023 10:54 PM
> To: Li,Rongqing <lirongqing@...du.com>; linux-s390@...r.kernel.org;
> netdev@...r.kernel.org
> Subject: Re: [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path
> when possible
> 
> On Thu, Nov 02, 2023 at 05:27:12PM +0800, Li RongQing wrote:
> >these is less opportunity that conn->tx_pushing is not 1, since
> 
> these -> there ?

Yes, thanks

> 
> >tx_pushing is just checked with 1, so move the setting tx_pushing to 1
> >after atomic_dec_and_test() return false, to avoid atomic_set and
> >smp_wmb in tx path when possible
> 
> The patch should add [PATCH net-next] subject-prefix since this is an
> optimization.
> 

OK

> Besides, do you have any performance number ?

Just try a simple performance test,  seems same.

-Li