netdev - Re: [PATCH net] tcp: fix fastopen code vs usec TS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169900322353.11636.7052991589260368750.git-patchwork-notify@kernel.org>
Date: Fri, 03 Nov 2023 09:20:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, eric.dumazet@...il.com, oliver.sang@...el.com,
 ncardwell@...gle.com, morleyd@...gle.com
Subject: Re: [PATCH net] tcp: fix fastopen code vs usec TS

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Tue, 31 Oct 2023 06:19:45 +0000 you wrote:
> After blamed commit, TFO client-ack-dropped-then-recovery-ms-timestamps
> packetdrill test failed.
> 
> David Morley and Neal Cardwell started investigating and Neal pointed
> that we had :
> 
> tcp_conn_request()
>   tcp_try_fastopen()
>    -> tcp_fastopen_create_child
>      -> child = inet_csk(sk)->icsk_af_ops->syn_recv_sock()
>        -> tcp_create_openreq_child()
>           -> copy req_usec_ts from req:
>           newtp->tcp_usec_ts = treq->req_usec_ts;
>           // now the new TFO server socket always does usec TS, no matter
>           // what the route options are...
>   send_synack()
>     -> tcp_make_synack()
>         // disable tcp_rsk(req)->req_usec_ts if route option is not present:
>         if (tcp_rsk(req)->req_usec_ts < 0)
>                 tcp_rsk(req)->req_usec_ts = dst_tcp_usec_ts(dst);
> 
> [...]

Here is the summary with links:
  - [net] tcp: fix fastopen code vs usec TS
    https://git.kernel.org/netdev/net/c/cdbab6236605

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html