netdev - Re: [PATCH v2] tg3: power down device only on SYSTEM_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 3 Nov 2023 17:49:03 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: George Shuklin <george.shuklin@...il.com>
Cc: netdev@...r.kernel.org, kai.heng.feng@...onical.com
Subject: Re: [PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

On Fri, Nov 3, 2023 at 5:21 PM George Shuklin <george.shuklin@...il.com> wrote:
>
> Dell R650xs servers hangs on reboot if tg3 driver calls
> tg3_power_down.
>
> This happens only if network adapters (BCM5720 for R650xs) were
> initialized using SNP (e.g. by booting ipxe.efi).
>
> The actual problem is on Dell side, but this fix allows servers
> to come back alive after reboot.
>
> Signed-off-by: George Shuklin <george.shuklin@...il.com>
> Fixes: 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER")
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 14b311196b8f..22b00912f7ac 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -18078,7 +18078,8 @@ static void tg3_shutdown(struct pci_dev *pdev)
>         if (netif_running(dev))
>                 dev_close(dev);
>
> -       tg3_power_down(tp);
> +       if (system_state == SYSTEM_POWER_OFF)
> +               tg3_power_down(tp);
>
>         rtnl_unlock();
>
> --
> 2.42.0
>
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
Thank you.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)