netdev - RE: [PATCH net-next 4/6] ice: Add support for E830 DDP package segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5059DAD2C742BBA1E3584BE397A4A@CO1PR11MB5059.namprd11.prod.outlook.com>
Date: Sat, 4 Nov 2023 02:13:37 +0000
From: "Nowlin, Dan" <dan.nowlin@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, David Miller
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Greenwalt, Paul" <paul.greenwalt@...el.com>,
	Simon Horman <horms@...nel.org>, "Brelinski, Tony" <tony.brelinski@...el.com>
Subject: RE: [PATCH net-next 4/6] ice: Add support for E830 DDP package
 segment

> On 11/3/2023 6:46 AM, Maciej Fijalkowski wrote:
>> On Wed, Oct 25, 2023 at 02:41:55PM -0700, Jacob Keller wrote:
>>> From: Dan Nowlin <dan.nowlin@...el.com>
>>>
>>> Add support for E830 DDP package segment. For the E830 package, 
>>> signature buffers will not be included inline in the configuration 
>>> buffers. Instead, the signature buffers will be located in a 
>>> signature segment.
>> 
>> This breaks E810 usage, they go into safe mode. I'll be sending a 
>> revert to this commit or if you have any other idea how to address 
>> that I'm all ears.
>> 
>
> Do we have any idea why it breaks? A fix might be preferable to a full revert if its simple.
>
> Thanks,
> Jake

Paul and I debugged this and found what is happening:

* Packages that do NOT have a signing segment are not being downloaded.
	- Any package before or equal to 1.3.25.0 does not have a signing segment, and thus will not be downloaded.

Paul and I have a patch that fixes this problem.

Can we get the version of the package that is failing to download?

Regards,
Dan