netdev - Re: [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 03 Nov 2023 20:27:30 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Jakub Sitnicki <jakub@...udflare.com>, 
 Liu Jian <liujian56@...wei.com>
Cc: john.fastabend@...il.com, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 andrii@...nel.org, 
 martin.lau@...ux.dev, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 kpsingh@...nel.org, 
 sdf@...gle.com, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 dsahern@...nel.org, 
 netdev@...r.kernel.org, 
 bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap
 skmsg redirect

Jakub Sitnicki wrote:
> On Sat, Oct 28, 2023 at 06:05 PM +08, Liu Jian wrote:
> > v6->v7: Rebase to latest bpf-next tree, and no changes.
> > v5->v6: Modified the description of the helper function.
> > v4->v5: Fix one refcount bug caused by patch1.
> > v3->v4: Change the two helpers's description.
> > 	Let BPF_F_PERMANENT takes precedence over apply/cork_bytes.
> >
> > Liu Jian (7):
> >   bpf, sockmap: add BPF_F_PERMANENT flag for skmsg redirect
> >   selftests/bpf: Add txmsg permanently test for sockmap
> >   selftests/bpf: Add txmsg redir permanently test for sockmap
> >   selftests/bpf: add skmsg verdict tests
> >   selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag
> >   selftests/bpf: add tests for verdict skmsg to itself
> >   selftests/bpf: add tests for verdict skmsg to closed socket
> >
> >  include/linux/skmsg.h                         |   1 +
> >  include/uapi/linux/bpf.h                      |  45 +++++--
> >  net/core/skmsg.c                              |   6 +-
> >  net/core/sock_map.c                           |   4 +-
> >  net/ipv4/tcp_bpf.c                            |  12 +-
> >  tools/include/uapi/linux/bpf.h                |  45 +++++--
> >  .../selftests/bpf/prog_tests/sockmap_basic.c  | 122 ++++++++++++++++++
> >  .../selftests/bpf/progs/test_sockmap_kern.h   |   3 +-
> >  .../bpf/progs/test_sockmap_msg_verdict.c      |  25 ++++
> >  tools/testing/selftests/bpf/test_sockmap.c    |  41 +++++-
> >  10 files changed, 272 insertions(+), 32 deletions(-)
> >  create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_verdict.c
> 
> I gave it one last look. For the series:
> 
> Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>

Ah I assumed the reviewed-bys were just carried through. So one more time,

Reviewed-by: John Fastabend <john.fastabend@...il.com>