lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZUegf5Od1rWxZ7rO@hoboy.vegasvil.org> Date: Sun, 5 Nov 2023 06:02:39 -0800 From: Richard Cochran <richardcochran@...il.com> To: Edward Adam Davis <eadavis@...com> Cc: davem@...emloft.net, habetsm.xilinx@...il.com, jeremy@...ine.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, reibax@...il.com, syzbot+df3f3ef31f60781fa911@...kaller.appspotmail.com Subject: Re: [PATCH net-next V6] ptp: fix corrupted list in ptp_open On Sun, Nov 05, 2023 at 05:36:41AM -0800, Richard Cochran wrote: > > @@ -44,6 +44,7 @@ struct ptp_clock { > > struct pps_device *pps_source; > > long dialed_frequency; /* remembers the frequency adjustment */ > > struct list_head tsevqs; /* timestamp fifo list */ > > + spinlock_t tsevqs_lock; /* one process at a time writing the timestamp fifo list*/ > > Please change this comment to "protects tsevqs from concurrent access" And please don't forget to take the spin lock around list_for_each_entry() in ptp_clock_event(). Thanks, Richard
Powered by blists - more mailing lists