lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <344fc5c2-4447-4481-843f-9d7720e55a77@lunn.ch> Date: Sun, 5 Nov 2023 16:33:29 +0100 From: Andrew Lunn <andrew@...n.ch> To: Mirsad Todorovac <mirsad.todorovac@....unizg.hr> Cc: Heiner Kallweit <hkallweit1@...il.com>, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, nic_swsd@...ltek.com Subject: Re: [PATCH net-next v6 0/5] Coalesce mac ocp write/modify calls to reduce spinlock contention > > > With about 130 of these sequential calls to r8168_mac_ocp_write() this looks like > > > a lock storm that will stall all of the cores and CPUs on the same memory controller > > > for certain time I/O takes to finish. Please provide benchmark data to show this is a real issue, and the patch fixes it. > Additionally, I would like to "inline" many functions, as I think that call/return > sequences with stack frame generation /destruction are more expensive than inlining the > small one liners. Please provide benchmarks to show the compiler is getting this wrong, and inline really is needed. Until there are benchmarks: NACK. Andrew
Powered by blists - more mailing lists