netdev - Re: [PATCH iwl-net v2] ice: fix DDP package download for packages without signature segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUkI1Oln+tPMyDD8@boxer>
Date: Mon, 6 Nov 2023 16:40:04 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Paul Greenwalt <paul.greenwalt@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
	<davem@...emloft.net>, <kuba@...nel.org>, <horms@...nel.org>,
	<tony.brelinski@...el.com>, Dan Nowlin <dan.nowlin@...el.com>
Subject: Re: [PATCH iwl-net v2] ice: fix DDP package download for packages
 without signature segment

On Mon, Nov 06, 2023 at 10:18:08AM -0500, Paul Greenwalt wrote:
> From: Dan Nowlin <dan.nowlin@...el.com>
> 
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> incorrectly removed support for package download for packages without a
> signature segment. These packages include the signature buffer inline
> in the configurations buffers, and not in a signature segment.
> 
> Fix package download by providing download support for both packages
> with (ice_download_pkg_with_sig_seg()) and without signature segment
> (ice_download_pkg_without_sig_seg()).
> 
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> ---
> Changelog
> v2->v3:

so is that a v3 or v2? subject says v2.

You should include tested-by and reviewed-by tags provided by me and
Wojciech.

> - correct Reported-by email address.
> ___
> 
>  drivers/net/ethernet/intel/ice/ice_ddp.c | 106 ++++++++++++++++++++++-
>  1 file changed, 103 insertions(+), 3 deletions(-)
> 

[...]