netdev - Re: [PATCH iwl-net] ice: fix DDP package download for packages without signature segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02bd5b19-a291-496c-803b-a0f1c760989c@intel.com>
Date: Sun, 5 Nov 2023 21:39:16 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Paul Greenwalt <paul.greenwalt@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <jesse.brandeburg@...el.com>,
	<anthony.l.nguyen@...el.com>, <davem@...emloft.net>, <kuba@...nel.org>,
	<horms@...nel.org>, <tony.brelinski@...el.com>, Dan Nowlin
	<dan.nowlin@...el.com>, <Fijalkowski@....codeaurora.org>, Maciej
	<maciej.fijalkowski@...el.com>
Subject: Re: [PATCH iwl-net] ice: fix DDP package download for packages
 without signature segment



On 11/4/2023 11:29 AM, Paul Greenwalt wrote:
> From: Dan Nowlin <dan.nowlin@...el.com>
> 
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> incorrectly removed support for package download for packages without a
> signature segment. These packages include the signature buffer inline
> in the configurations buffers, and do not in a signature segment.
> 
> Fix package download by providing download support for both packages
> with (ice_download_pkg_with_sig_seg()) and without signature segment
> (ice_download_pkg_without_sig_seg()).
> 
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>