netdev - Re: [PATCH net v2] netfilter: xt_recent: fix (increase) ipv6 literal buffer length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231107171103.GA316877@kernel.org>
Date: Tue, 7 Nov 2023 12:11:03 -0500
From: Simon Horman <horms@...nel.org>
To: Maciej Żenczykowski <maze@...gle.com>
Cc: Maciej Żenczykowski <zenczykowski@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Florian Westphal <fw@...len.de>,
	Linux Network Development Mailing List <netdev@...r.kernel.org>,
	Netfilter Development Mailing List <netfilter-devel@...r.kernel.org>,
	Jan Engelhardt <jengelh@...i.de>, Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net v2] netfilter: xt_recent: fix (increase) ipv6 literal
 buffer length

On Sun, Nov 05, 2023 at 11:56:00AM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <zenczykowski@...il.com>
> 
> in6_pton() supports 'low-32-bit dot-decimal representation'
> (this is useful with DNS64/NAT64 networks for example):
> 
>   # echo +aaaa:bbbb:cccc:dddd:eeee:ffff:1.2.3.4 > /proc/self/net/xt_recent/DEFAULT
>   # cat /proc/self/net/xt_recent/DEFAULT
>   src=aaaa:bbbb:cccc:dddd:eeee:ffff:0102:0304 ttl: 0 last_seen: 9733848829 oldest_pkt: 1 9733848829
> 
> but the provided buffer is too short:
> 
>   # echo +aaaa:bbbb:cccc:dddd:eeee:ffff:255.255.255.255 > /proc/self/net/xt_recent/DEFAULT
>   -bash: echo: write error: Invalid argument
> 
> Cc: Jan Engelhardt <jengelh@...i.de>
> Cc: Patrick McHardy <kaber@...sh.net>
> Fixes: 079aa88fe717 ("netfilter: xt_recent: IPv6 support")
> Signed-off-by: Maciej Żenczykowski <zenczykowski@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>