netdev - Re: [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZUnVhxktZCpFYwEg@hoboy.vegasvil.org>
Date: Mon, 6 Nov 2023 22:13:27 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Edward Adam Davis <eadavis@...com>
Cc: davem@...emloft.net, habetsm.xilinx@...il.com, jeremy@...ine.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	reibax@...il.com,
	syzbot+df3f3ef31f60781fa911@...kaller.appspotmail.com
Subject: Re: [PATCH net-next V8 2/2] ptp: fix corrupted list in ptp_open

On Mon, Nov 06, 2023 at 10:31:28PM +0800, Edward Adam Davis wrote:
> There is no lock protection when writing ptp->tsevqs in ptp_open() and
> ptp_release(), which can cause data corruption, use spin lock to avoid this
> issue.
> 
> Moreover, ptp_release() should not be used to release the queue in ptp_read(),
> and it should be deleted altogether.
> 
> Reported-and-tested-by: syzbot+df3f3ef31f60781fa911@...kaller.appspotmail.com
> Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers")
> Signed-off-by: Edward Adam Davis <eadavis@...com>

(This should go to net and not net-next.)

Acked-by: Richard Cochran <richardcochran@...il.com>