lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Nov 2023 17:10:09 -0700
From: David Ahern <>
To: Mina Almasry <>
 "David S. Miller" <>, Eric Dumazet <>,
 Jakub Kicinski <>, Paolo Abeni <>,
 Jesper Dangaard Brouer <>,
 Ilias Apalodimas <>, Arnd Bergmann
 <>, Willem de Bruijn <>,
 Shuah Khan <>, Sumit Semwal <>,
 Christian König <>,
 Shakeel Butt <>, Jeroen de Borst <>,
 Praveen Kaligineedi <>,
 Willem de Bruijn <>, Kaiyuan Zhang <>
Subject: Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory

On 11/7/23 5:02 PM, Mina Almasry wrote:
> On Mon, Nov 6, 2023 at 1:02 PM Stanislav Fomichev <> wrote:
>> On 11/05, Mina Almasry wrote:
>>> +static inline bool page_is_page_pool_iov(const struct page *page)
>>> +{
>>> +     return (unsigned long)page & PP_DEVMEM;
>>> +}
>> Speaking of bpf: one thing that might be problematic with this PP_DEVMEM
>> bit is that it will make debugging with bpftrace a bit (more)
>> complicated. If somebody were trying to get to that page_pool_iov from
>> the frags, they will have to do the equivalent of page_is_page_pool_iov,
>> but probably not a big deal? (thinking out loud)
> Good point, but that doesn't only apply to bpf I think. I'm guessing
> even debugger drgn access to the bv_page in the frag will have trouble
> if it's actually accessing an iov with LSB set.
> But this is not specific to this use for LSB pointer trick. I think
> all code that currently uses LSB pointer trick will have similar
> troubles. In this context my humble vote is that we get such big
> upside from reducing code churn that it's reasonable to tolerate such
> side effects.


> I could alleviate some of the issues by teaching drgn to do the right
> thing for devmem/iovs... time permitting.
Tools like drgn and crash have to know when the LSB trick is used  -
e.g., dst_entry - and handle it when dereferencing pointers.

Powered by blists - more mailing lists