netdev - Re: [PATCH net] ipvlan: add ipvlan_route_v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+BhRbK-HfmYzzr37N+E_-6kCeoZU0W8n7V35ERZR4A_A@mail.gmail.com>
Date: Thu, 9 Nov 2023 19:31:33 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	syzbot <syzkaller@...glegroups.com>, Mahesh Bandewar <maheshb@...gle.com>, 
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] ipvlan: add ipvlan_route_v6_outbound() helper

On Thu, Nov 9, 2023 at 7:29 PM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:

> Do you think that it is an oversight that this function mixes a return
> of NET_XMIT_DROP/NET_XMIT_SUCCESS with returning the error code
> received from deep in the routing stack?
>
> Either way, this patch preserves that existing behavior, so
>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>

I saw this indeed, and chose to leave this as is to ease code review.

We might send a stand alone patch to return NET_XMIT_DROP instead.

Thanks for the review !