netdev - Re: [PATCH] iphase: Adding a null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231108184049.1f27de01@kernel.org>
Date: Wed, 8 Nov 2023 18:40:49 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Andrey Shumilin <shum.sdl@...ct.ru>
Cc: 3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org, khoroshilov@...ras.ru, ykarpov@...ras.ru,
 vmerzlyakov@...ras.ru, vefanov@...ras.ru
Subject: Re: [PATCH] iphase: Adding a null pointer check

On Tue,  7 Nov 2023 15:36:00 +0300 Andrey Shumilin wrote:
> The pointer <dev->desc_tbl[i].iavcc> is dereferenced on line 195.
> Further in the code, it is checked for null on line 204.
> It is proposed to add a check before dereferencing the pointer.

How do you know this is the right way to address the problem.
Much easier to debug a crash than misbehaving driver.

This is ancient code, leave it be.
-- 
pw-bot: reject
pv-bot: nit