netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 07/15] ice: remove VF pointer reference in eswitch code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 9 Nov 2023 10:21:35 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Drewek, Wojciech" <wojciech.drewek@...el.com>, "Szycik, Marcin"
	<marcin.szycik@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Raczynski, Piotr" <piotr.raczynski@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 07/15] ice: remove VF
 pointer reference in eswitch code

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Tuesday, October 24, 2023 4:39 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Drewek, Wojciech <wojciech.drewek@...el.com>; Szycik, Marcin
> <marcin.szycik@...el.com>; netdev@...r.kernel.org; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>; Raczynski, Piotr
> <piotr.raczynski@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 07/15] ice: remove VF pointer
> reference in eswitch code
> 
> Make eswitch code generic by removing VF pointer reference in functions.
> It is needed to support eswitch mode for other type of devices.
> 
> Previously queue id used for Rx was based on VF number. Use ::q_id saved in
> port representor instead.
> 
> After adding or removing port representor ::q_id value can change. It isn't
> good idea to iterate over representors list using this value.
> Use xa_find starting from the first one instead to get next port representor to
> remap.
> 
> The number of port representors has to be equal to ::num_rx/tx_q. Warn if it
> isn't true.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_eswitch.c | 39 ++++++++++----------
> drivers/net/ethernet/intel/ice/ice_eswitch.h |  5 ++-
>  drivers/net/ethernet/intel/ice/ice_repr.c    |  1 +
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c  |  2 +-
>  4 files changed, 25 insertions(+), 22 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>