netdev - [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbc536dd-f64e-4ccf-89df-3afbe02b59ca@siemens.com>
Date: Fri, 10 Nov 2023 17:13:08 +0100
From: Jan Kiszka <jan.kiszka@...mens.com>
To: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, MD Danish Anwar <danishanwar@...com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@...mens.com>,
 Nishanth Menon <nm@...com>,
 "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@...mens.com>,
 Wojciech Drewek <wojciech.drewek@...el.com>,
 Roger Quadros <rogerq@...nel.org>
Subject: [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing
 pruss_request_mem_region

From: Jan Kiszka <jan.kiszka@...mens.com>

We were just continuing in this case, surely not desired.

Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
---

Changes in v3:
 - no functional ones
 - added original author in CC with new address

Changes in v2:
 - add proper tags

 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3abbeba26f1b..411898a4f38c 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev)
 				       &prueth->shram);
 	if (ret) {
 		dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
-		pruss_put(prueth->pruss);
+		goto put_pruss;
 	}

 	prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
@@ -2215,6 +2215,8 @@ static int prueth_probe(struct platform_device *pdev)

 put_mem:
 	pruss_release_mem_region(prueth->pruss, &prueth->shram);
+
+put_pruss:
 	pruss_put(prueth->pruss);

 put_cores:
-- 
2.35.3