netdev - Re: [PATCH net] ptp: annotate data-race around q->head and q->tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZU5j2V9aUae0FE1o@hoboy.vegasvil.org>
Date: Fri, 10 Nov 2023 09:09:45 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] ptp: annotate data-race around q->head and q->tail

On Fri, Nov 10, 2023 at 10:42:01AM +0100, Eric Dumazet wrote:

> I do not see how races are solved... Shouldn't
> pccontext->private_clkdata be protected by RCU ?

Yeah, the test is useless, because the memory is allocated in open()
and later freed in release().  During ioctl() the pointer must be
valid.

However, there was a bogus call to ptp_release() in the read() method,
but that has now been removed, and so the test is now bogus.

Thanks,
Richard