netdev - Re: [PATCH net] net: gso_test: support CONFIG_MAX_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 12 Nov 2023 10:14:11 +0000
From: Simon Horman <horms@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] net: gso_test: support CONFIG_MAX_SKB_FRAGS up to 45

On Fri, Nov 10, 2023 at 10:36:00AM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> The test allocs a single page to hold all the frag_list skbs. This
> is insufficient on kernels with CONFIG_MAX_SKB_FRAGS=45, due to the
> increased skb_shared_info frags[] array length.
> 
>         gso_test_func: ASSERTION FAILED at net/core/gso_test.c:210
>         Expected alloc_size <= ((1UL) << 12), but
>             alloc_size == 5075 (0x13d3)
>             ((1UL) << 12) == 4096 (0x1000)
> 
> Simplify the logic. Just allocate a page for each frag_list skb.
> 
> Fixes: 4688ecb1385f ("net: expand skb_segment unit test with frag_list coverage")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Thanks Willem,

I agree that the logic does as described,
that it should resolve the flagged problem,
and that as a bonus it is a nice simplification.

Reviewed-by: Simon Horman <horms@...nel.org>