netdev - Re: [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m234xb5hmh.fsf@ja.int.chopps.org>
Date: Sun, 12 Nov 2023 06:35:17 -0500
From: Christian Hopps <chopps@...n.net>
To: Simon Horman <horms@...nel.org>
Cc: Christian Hopps <chopps@...pps.org>, devel@...ux-ipsec.org, Steffen
 Klassert <steffen.klassert@...unet.com>, netdev@...r.kernel.org, Christian
 Hopps <chopps@...n.net>
Subject: Re: [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl


Simon Horman <horms@...nel.org> writes:

> On Fri, Nov 10, 2023 at 06:37:19AM -0500, Christian Hopps wrote:
>> From: Christian Hopps <chopps@...n.net>
>>
>> Add a new xfrm mode implementing AggFrag/IP-TFS from RFC9347.
>>
>> This utilizes the new xfrm_mode_cbs to implement demand-driven IP-TFS
>> functionality. This functionality can be used to increase bandwidth
>> utilization through small packet aggregation, as well as help solve PMTU
>> issues through it's efficient use of fragmentation.
>>
>> Link: https://www.rfc-editor.org/rfc/rfc9347.txt
>>
>> Signed-off-by: Christian Hopps <chopps@...n.net>
>
> ...
>
>> diff --git a/net/xfrm/xfrm_iptfs.c b/net/xfrm/xfrm_iptfs.c
>
> ...
>
>> +/* ================= */
>> +/* Utility Functions */
>> +/* ================= */
>> +
>> +static inline u32 __trace_ip_proto(struct iphdr *iph)
>> +{
>> +	if (iph->version == 4)
>> +		return iph->protocol;
>> +	return ((struct ipv6hdr *)iph)->nexthdr;
>> +}
>
> Hi Christian,
>
> please don't use inline in .c files unless there is a demonstrable reason
> to do so. Rather, please leave inlining up to the compiler.

Removed all cases.

Thanks,
Chris.

>
> ...


Download attachment "signature.asc" of type "application/pgp-signature" (859 bytes)