netdev - Re: [RFC net-next 3/5] net: dsa: realtek: create realtek-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZShX2d8EJheuNEVpC=Tf3oP53Khs071XFccTskfY1b1A@mail.gmail.com>
Date: Mon, 13 Nov 2023 09:35:23 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, alsi@...g-olufsen.dk, andrew@...n.ch, 
	vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com, 
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org, 
	krzk+dt@...nel.org, arinc.unal@...nc9.com
Subject: Re: [RFC net-next 3/5] net: dsa: realtek: create realtek-common

On Sat, Nov 11, 2023 at 10:57 PM Luiz Angelo Daros de Luca
<luizluca@...il.com> wrote:

> Some code can be shared between both interface modules (MDIO and SMI)
> and amongst variants. For now, these interface functions are shared:
>
> - realtek_common_lock
> - realtek_common_unlock
> - realtek_common_probe
> - realtek_common_remove
>
> The reset during probe was moved to the last moment before a variant
> detects the switch. This way, we avoid a reset if anything else fails.
>
> The symbols from variants used in of_match_table are now in a single
> match table in realtek-common, used by both interfaces.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>

As Krzysztof explained the dev_err_probe() call already prints
ret. With that fixed:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij