netdev - Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcfdc6f05926db494ea0105e5523cc21ecfdf4e7.camel@gmail.com>
Date: Mon, 13 Nov 2023 11:07:01 +0100
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Andy Shevchenko <andy@...nel.org>, nikita.shubin@...uefel.me
Cc: Hartley Sweeten <hsweeten@...ionengravers.com>, Lennert Buytenhek
 <kernel@...tstofly.org>, Russell King <linux@...linux.org.uk>, Lukasz
 Majewski <lukma@...x.de>, Linus Walleij <linus.walleij@...aro.org>, Bartosz
 Golaszewski <brgl@...ev.pl>, Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>,  Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Daniel Lezcano
 <daniel.lezcano@...aro.org>,  Thomas Gleixner <tglx@...utronix.de>,
 Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
  Guenter Roeck <linux@...ck-us.net>, Sebastian Reichel <sre@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Mark
 Brown <broonie@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>, Vinod Koul <vkoul@...nel.org>, Miquel Raynal
 <miquel.raynal@...tlin.com>,  Richard Weinberger <richard@....at>, Vignesh
 Raghavendra <vigneshr@...com>, Damien Le Moal <dlemoal@...nel.org>, Sergey
 Shtylyov <s.shtylyov@....ru>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
 soc@...nel.org, Liam Girdwood <lgirdwood@...il.com>,  Jaroslav Kysela
 <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Michael Peters
 <mpeters@...eddedts.com>, Kris Bahnsen <kris@...eddedts.com>, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org, 
 linux-watchdog@...r.kernel.org, linux-pm@...r.kernel.org, 
 linux-pwm@...r.kernel.org, linux-spi@...r.kernel.org,
 netdev@...r.kernel.org,  dmaengine@...r.kernel.org,
 linux-mtd@...ts.infradead.org,  linux-ide@...r.kernel.org,
 linux-input@...r.kernel.org,  alsa-devel@...a-project.org
Subject: Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset

Hi Andy!

On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:
> > +       /* Issue the reboot */
            ^^^^^^^^^^^^^^^^^^^^^^
This is the relevant comment, one can extend it, but looks already quite
informative considering EP93XX_SYSCON_DEVCFG_SWRST register name.

But Nikita would be able to include more verbose comment if
you'd have a suggestion.

> > +       ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00);
> > +       ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST);
> 
> 
> > +       mdelay(1000);
> 
> Atomic?! Such a huge delay must be explained, esp. why it's atomic.

-- 
Alexander Sverdlin.