netdev - Re: [PATCH net-next v2 08/21] virtio_net: sq support premapped mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEuvdA1xWtLLsV49XCGwD8S+AXDkHeq2K3-AsqgWixZVXg@mail.gmail.com>
Date: Tue, 14 Nov 2023 12:27:20 +0800
From: Jason Wang <jasowang@...hat.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"Michael S. Tsirkin" <mst@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, 
	virtualization@...ts.linux-foundation.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v2 08/21] virtio_net: sq support premapped mode

On Tue, Nov 14, 2023 at 11:59 AM Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
>
> On Tue, 14 Nov 2023 11:55:52 +0800, Jason Wang <jasowang@...hat.com> wrote:
> > On Tue, Nov 14, 2023 at 11:42 AM Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
> > >
> > > On Tue, 14 Nov 2023 11:26:42 +0800, Jason Wang <jasowang@...hat.com> wrote:
> > > > On Thu, Nov 9, 2023 at 7:06 PM Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
> > > > >
> > > > > On Thu, 9 Nov 2023 14:37:38 +0800, Jason Wang <jasowang@...hat.com> wrote:
> > > > > > On Tue, Nov 7, 2023 at 11:12 AM Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
> > > > > > >
> > > > > > > If the xsk is enabling, the xsk tx will share the send queue.
> > > > > > > But the xsk requires that the send queue use the premapped mode.
> > > > > > > So the send queue must support premapped mode.
> > > > > > >
> > > > > > > Signed-off-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> > > > > > > ---
> > > > > > >  drivers/net/virtio/main.c       | 163 ++++++++++++++++++++++++++++----
> > > > > > >  drivers/net/virtio/virtio_net.h |  16 ++++
> > > > > > >  2 files changed, 163 insertions(+), 16 deletions(-)
> > > > > > >
> >
> > [...]
> >
> > > > > >
> > > > > > I think we need to seek a way to reuse what has been stored by virtio
> > > > > > core. It should be much more efficient.
> > > > >
> > > > >
> > > > > Yes.
> > > > >
> > > > > But that is for net-next branch.
> > > > >
> > > > > Can we do that as a fix after that is merged to 6.8?
> > > >
> > > > We still have time. I would like to do it from the start.
> > >
> > >
> > > I want to finish the job including new AF_XDP ZC feature.
> > > Because that this must wait the merge window.
> > > Base on that, the optimizing work can be done everytime.
> > >
> > > If we work from the new virtio prepare, that can be merged to 6.8.
> > > And the AF_XDP zc must wait 6.9. right?
> >
> > It can be part of this series. Or anything I missed?
> >
> > My understanding is that, since the information is handy, it just
> > requires new helpers. So I don't expect it needs a large series.
>
> Now, this is pushing to net-next.
>
> If we add an new virtio-core helper. That must be pushed to virtio branch.
> And this patch set must wait that.

I don't think so if it's just a matter of new helpers. The
acknowledgement from the virtio maintainer should be sufficient.

Let's just try and see?

THanks

>
> Thanks.
>
>
> >
> > Thanks
> >
> > >
> > > Thanks
> > >
> >
>