netdev - Re: [PATCH net-next v2 1/2] net: stmmac: remove extra newline from descriptors display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <la55hpdihraxfe4u35w6kyurkkjqij7ss5qpirehat47hwzo62@aj5qku6vypdi>
Date: Tue, 14 Nov 2023 15:05:59 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Baruch Siach <baruch@...s.co.il>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: stmmac: remove extra newline from
 descriptors display

On Tue, Nov 14, 2023 at 09:03:09AM +0200, Baruch Siach wrote:
> One newline per line should be enough. Reduce the verbosity of
> descriptors dump.

Why not. Thanks.
Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

> 
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 3e50fd53a617..39336fe5e89d 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -6202,7 +6202,6 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
>  				   le32_to_cpu(p->des2), le32_to_cpu(p->des3));
>  			p++;
>  		}
> -		seq_printf(seq, "\n");
>  	}
>  }
>  
> -- 
> 2.42.0
> 
>