netdev - Re: [PATCH net-next 1/2] igc: Simplify setting flags in the TX data descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520ef11d-6433-465e-867b-13f8f571828e@engleder-embedded.com>
Date: Tue, 14 Nov 2023 20:16:48 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org
Cc: Vinicius Costa Gomes <vinicius.gomes@...el.com>, sasha.neftin@...el.com,
 richardcochran@...il.com, maciej.fijalkowski@...el.com,
 magnus.karlsson@...el.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, bpf@...r.kernel.org,
 Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net-next 1/2] igc: Simplify setting flags in the TX data
 descriptor

On 14.11.23 19:36, Tony Nguyen wrote:
> From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> 
> We can re-use the IGC_SET_FLAG() macro to simplify setting some values
> in the TX data descriptor. With the macro it's easier to get the
> meaning of the operations.
> 
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Tested-by: Naama Meir <naamax.meir@...ux.intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index e9bb403bbacf..7059710154eb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1299,14 +1299,12 @@ static void igc_tx_olinfo_status(struct igc_ring *tx_ring,
>   	u32 olinfo_status = paylen << IGC_ADVTXD_PAYLEN_SHIFT;
>   
>   	/* insert L4 checksum */
> -	olinfo_status |= (tx_flags & IGC_TX_FLAGS_CSUM) *
> -			  ((IGC_TXD_POPTS_TXSM << 8) /
> -			  IGC_TX_FLAGS_CSUM);
> +	olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_CSUM,
> +				      (IGC_TXD_POPTS_TXSM << 8));
>   
>   	/* insert IPv4 checksum */
> -	olinfo_status |= (tx_flags & IGC_TX_FLAGS_IPV4) *
> -			  (((IGC_TXD_POPTS_IXSM << 8)) /
> -			  IGC_TX_FLAGS_IPV4);
> +	olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_IPV4,
> +				      (IGC_TXD_POPTS_IXSM << 8));
>   
>   	tx_desc->read.olinfo_status = cpu_to_le32(olinfo_status);
>   }

Reviewed-by: Gerhard Engleder <gerhard@...leder-embedded.com>