lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 14 Nov 2023 11:56:54 -0800
From: Mat Martineau <>
To: Matthieu Baerts <>, 
 "David S. Miller" <>, Eric Dumazet <>, 
 Jakub Kicinski <>, Paolo Abeni <>
 Mat Martineau <>, Geliang Tang <>
Subject: [PATCH net-next v2 12/15] selftests: mptcp: add missing

From: Geliang Tang <>

In we are missing something like "oflag=append"
because this will write "${rem}" bytes at the beginning of the file
where there is already some random bytes. It should write that at
the end.

This patch adds this missing 'oflag=append' flag for 'dd' command in

Suggested-by: Matthieu Baerts <>
Reviewed-by: Matthieu Baerts <>
Signed-off-by: Geliang Tang <>
Signed-off-by: Mat Martineau <>
 tools/testing/selftests/net/mptcp/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/ b/tools/testing/selftests/net/mptcp/
index 3b971d1617d8..c4f08976c418 100755
--- a/tools/testing/selftests/net/mptcp/
+++ b/tools/testing/selftests/net/mptcp/
@@ -593,7 +593,7 @@ make_file()
 	rem=$((SIZE - (ksize * 1024)))
 	dd if=/dev/urandom of="$name" bs=1024 count=$ksize 2> /dev/null
-	dd if=/dev/urandom conv=notrunc of="$name" bs=1 count=$rem 2> /dev/null
+	dd if=/dev/urandom conv=notrunc of="$name" oflag=append bs=1 count=$rem 2> /dev/null
 	echo -e "\nMPTCP_TEST_FILE_END_MARKER" >> "$name"
 	echo "Created $name (size $(du -b "$name")) containing data sent by $who"


Powered by blists - more mailing lists