lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 14 Nov 2023 23:18:27 +0100
From: Andrew Lunn <>
To: Christian Marangi <>
Cc: "David S. Miller" <>,
	Eric Dumazet <>,
	Jakub Kicinski <>, Paolo Abeni <>,
	Rob Herring <>,
	Krzysztof Kozlowski <>,
	Conor Dooley <>,
	Heiner Kallweit <>,
	Russell King <>,
	Robert Marko <>,
	Vladimir Oltean <>,,,
Subject: Re: [net-next PATCH v8 3/4] net: phy: aquantia: add firmware load

On Tue, Nov 14, 2023 at 03:08:43PM +0100, Christian Marangi wrote:
> From: Robert Marko <>
> Aquantia PHY-s require firmware to be loaded before they start operating.
> It can be automatically loaded in case when there is a SPI-NOR connected
> to Aquantia PHY-s or can be loaded from the host via MDIO.
> This patch adds support for loading the firmware via MDIO as in most cases
> there is no SPI-NOR being used to save on cost.
> Firmware loading code itself is ported from mainline U-boot with cleanups.
> The firmware has mixed values both in big and little endian.
> PHY core itself is big-endian but it expects values to be in little-endian.
> The firmware is little-endian but CRC-16 value for it is stored at the end
> of firmware in big-endian.
> It seems the PHY does the conversion internally from firmware that is
> little-endian to the PHY that is big-endian on using the mailbox
> but mailbox returns a big-endian CRC-16 to verify the written data
> integrity.
> Co-developed-by: Christian Marangi <>
> Signed-off-by: Robert Marko <>
> Signed-off-by: Christian Marangi <>

Reviewed-by: Andrew Lunn <>


Powered by blists - more mailing lists