lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231115144007.478111-4-herve.codina@bootlin.com> Date: Wed, 15 Nov 2023 15:39:39 +0100 From: Herve Codina <herve.codina@...tlin.com> To: Herve Codina <herve.codina@...tlin.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Qiang Zhao <qiang.zhao@....com>, Li Yang <leoyang.li@....com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Shengjiu Wang <shengjiu.wang@...il.com>, Xiubo Li <Xiubo.Lee@...il.com>, Fabio Estevam <festevam@...il.com>, Nicolin Chen <nicoleotsuka@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, Randy Dunlap <rdunlap@...radead.org> Cc: netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, alsa-devel@...a-project.org, Simon Horman <horms@...nel.org>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, Thomas Petazzoni <thomas.petazzoni@...tlin.com> Subject: [PATCH v9 03/27] soc: fsl: cpm1: qmc: Fix rx channel reset The qmc_chan_reset_rx() set the is_rx_stopped flag. This leads to an inconsistent state in the following sequence. qmc_chan_stop() qmc_chan_reset() Indeed, after the qmc_chan_reset() call, the channel must still be stopped. Only a qmc_chan_start() call can move the channel from stopped state to started state. Fix the issue removing the is_rx_stopped flag setting from qmc_chan_reset() Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC") Signed-off-by: Herve Codina <herve.codina@...tlin.com> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu> --- drivers/soc/fsl/qe/qmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 3f3de1351c96..2312152a44b3 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -685,7 +685,6 @@ static void qmc_chan_reset_rx(struct qmc_chan *chan) qmc_read16(chan->s_param + QMC_SPE_RBASE)); chan->rx_pending = 0; - chan->is_rx_stopped = false; spin_unlock_irqrestore(&chan->rx_lock, flags); } -- 2.41.0
Powered by blists - more mailing lists