netdev - Re: [PATCH net] s390/ism: ism driver implies smc protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8130636d3a46329a5f18cc55ec4946d4adb8c9f5.camel@linux.ibm.com>
Date: Wed, 15 Nov 2023 16:29:21 +0100
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: Simon Horman <horms@...nel.org>
Cc: Alexandra Winter <wintera@...ux.ibm.com>,
        Wenjia Zhang
 <wenjia@...ux.ibm.com>, Paolo Abeni <pabeni@...hat.com>,
        Wen Gu
 <guwen@...ux.alibaba.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander
 Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger
 <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, alibuda@...ux.alibaba.com,
        tonylu@...ux.alibaba.com, dust.li@...ux.alibaba.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] s390/ism: ism driver implies smc protocol

On Wed, 2023-11-15 at 10:23 +0000, Simon Horman wrote:
> Hi Gerd,
> 
> In a similar vein, I am wondering if the forward declaration of
> ism_ops could be removed.  In my very light compile test it shows up
> as unused when CONFIG_SMC is unset.

Hi Simon,

sure, will do. Guess I need to make it a habit to compile with W=1.
ism (and smc) need some more work, though anyway.
I'll send a v2.

Thanks for spotting this!

Gerd