netdev - Re: [PATCH iproute2 v2] Makefile: use /usr/share/iproute2 for config files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMw=ZnT2YN++vvUhordyRYCgj-F3kN112sZZXvZvH-ge_nwJwQ@mail.gmail.com>
Date: Wed, 15 Nov 2023 17:39:04 +0000
From: Luca Boccassi <bluca@...ian.org>
To: Andrea Claudi <aclaudi@...hat.com>
Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>, 
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2 v2] Makefile: use /usr/share/iproute2 for config files

On Wed, 15 Nov 2023 at 17:25, Andrea Claudi <aclaudi@...hat.com> wrote:
>
> According to FHS:
>
> "/usr/lib includes object files and libraries. On some systems, it may
> also include internal binaries that are not intended to be executed
> directly by users or shell scripts."
>
> A better directory to store config files is /usr/share:
>
> "The /usr/share hierarchy is for all read-only architecture independent
> data files.
>
> This hierarchy is intended to be shareable among all architecture
> platforms of a given OS; thus, for example, a site with i386, Alpha, and
> PPC platforms might maintain a single /usr/share directory that is
> centrally-mounted."
>
> Accordingly, move configuration files to $(DATADIR)/iproute2.
>
> Fixes: 946753a4459b ("Makefile: ensure CONF_USR_DIR honours the libdir config")
> Reported-by: Luca Boccassi <luca.boccassi@...il.com>
> Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> ---
>
> v2:
> - Rebased on commit deb66acabe44, changed commit message
>
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a24844cf..8024d45e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -16,12 +16,12 @@ endif
>
>  PREFIX?=/usr
>  SBINDIR?=/sbin
> -CONF_ETC_DIR?=/etc/iproute2
> -CONF_USR_DIR?=$(PREFIX)/lib/iproute2
>  NETNS_RUN_DIR?=/var/run/netns
>  NETNS_ETC_DIR?=/etc/netns
>  DATADIR?=$(PREFIX)/share
>  HDRDIR?=$(PREFIX)/include/iproute2
> +CONF_ETC_DIR?=/etc/iproute2
> +CONF_USR_DIR?=$(DATADIR)/iproute2
>  DOCDIR?=$(DATADIR)/doc/iproute2
>  MANDIR?=$(DATADIR)/man
>  ARPDDIR?=/var/lib/arpd

Acked-by: Luca Boccassi <bluca@...ian.org>