netdev - Re: [PATCH net 1/2] net: stmmac: fix rx budget limit check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 15 Nov 2023 04:00:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Baruch Siach <baruch@...s.co.il>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: stmmac: fix rx budget limit check

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 13 Nov 2023 19:42:49 +0200 you wrote:
> The while loop condition verifies 'count < limit'. Neither value change
> before the 'count >= limit' check. As is this check is dead code. But
> code inspection reveals a code path that modifies 'count' and then goto
> 'drain_data' and back to 'read_again'. So there is a need to verify
> count value sanity after 'read_again'.
> 
> Move 'read_again' up to fix the count limit check.
> 
> [...]

Here is the summary with links:
  - [net,1/2] net: stmmac: fix rx budget limit check
    https://git.kernel.org/netdev/net/c/fa02de9e7588
  - [net,2/2] net: stmmac: avoid rx queue overrun
    https://git.kernel.org/netdev/net/c/b6cb4541853c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html