netdev - Re: [RFC PATCHv3 net-next 02/10] net: bridge: add document for IFLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVSFBcC+bv3hR6kR@Laptop-X1>
Date: Wed, 15 Nov 2023 16:44:53 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Ido Schimmel <idosch@...sch.org>, Roopa Prabhu <roopa@...dia.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Florian Westphal <fw@...len.de>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [RFC PATCHv3 net-next 02/10] net: bridge: add document for
 IFLA_BRPORT enum

On Mon, Nov 13, 2023 at 11:44:21AM +0200, Nikolay Aleksandrov wrote:
> > + * @IFLA_BRPORT_LEARNING
> > + *   Controls whether a given port will learn MAC addresses from received
> > + *   traffic or not. If learning if off, the bridge will end up flooding any
> > + *   traffic for which it has no FDB entry. By default this flag is on.
> 
> The second sentence is not necessary, that is the default behaviour
> for unknown destinations whether learning is enabled or not, it has no
> effect on it. You can mention that it learns source MAC addresses
> explicitly.

Thanks, I will change this paragraph to:

Controls whether a given port will learn *source* MAC addresses from
received traffic or not. By default this flag is on.

Hangbin